Fix #556, make focus navigation work when shadow host's tabindex is -1 #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is -1 The Shadow DOM spec section 6.3 (sequential focus navigation) unintentionally excluded all shadow hosts with nagative tabindex in Step 3.1.3. This was unexpected for shadow hosts with `delagatesFocus=false` shadow root. Before: - Exclude all shadow hosts with tabindex < 0 After: - Allow shadow hosts with tabindex < 0, but only when `delegatesFocus=false` - In sorting by tabindex, treat such shadow hosts as `tabindex=0` - Exclude those shadow hosts in Step 4.
| <li>Otherwise, append <var>ELEMENT</var> to <var>NAVIGATION-ORDER</var>.</li> | ||
| </ol> | ||
| </li> | ||
| <li>Otherwise if <var>ELEMENT</var> is focusable, or a <a>slot element</a>, and its <a>tabindex</a> value is not negative, append <var>ELEMENT</var> to <var>NAVIGATION-ORDER</var>.</li> |
There was a problem hiding this comment.
The "and", "or" relationship are confusing. Could you make this explicit?
Donsdon
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Shadow DOM spec section 6.3 (sequential focus navigation) unintentionally excluded all shadow hosts with nagative tabindex in Step 3.1.3. This was unexpected for shadow hosts with
delagatesFocus=falseshadow root.Before:
After:
delegatesFocus=falsetabindex=0